Skip to content

Collect usage of GlobalConfiguration resources #5415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 18, 2024

Conversation

shaun-nx
Copy link
Contributor

@shaun-nx shaun-nx commented Apr 17, 2024

Proposed changes

Resolves #5141

Updates telemetry to collect the usage of a GlobalConfiguration resource.
Since a single install of the Ingress Controller can only have one GlobalConfiguration resource, this is set as either true or false instead of being a count

Example data:

{
  Data: {
    ProjectName:NIC 
    ProjectVersion:3.6.0-SNAPSHOT
    ...
  }
  NICResourceCounts: { 
    ...
    GlobalConfiguration:false
  }
}

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@shaun-nx shaun-nx requested review from a team as code owners April 17, 2024 12:59
@github-actions github-actions bot added documentation Pull requests/issues for documentation go Pull requests that update Go code labels Apr 17, 2024
@shaun-nx shaun-nx enabled auto-merge (squash) April 17, 2024 13:32
Copy link
Contributor

@jjngx jjngx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM docs-wise!

@shaun-nx shaun-nx merged commit aee7592 into main Apr 18, 2024
@shaun-nx shaun-nx deleted the telemety/globalconfiguration-usage branch April 18, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collect use of GlobalConfiguration
4 participants