Skip to content

Feat/ignore helm secrets #3088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 28 commits into from
Sep 26, 2022
Merged

Feat/ignore helm secrets #3088

merged 28 commits into from
Sep 26, 2022

Conversation

shaun-nx
Copy link
Contributor

@shaun-nx shaun-nx commented Sep 22, 2022 •
edited
Loading

Proposed changes

This change will filter out secrets of type helm.sh/release.v1 from the k8s api.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

“shaun-nx” added 19 commits July 25, 2022 15:56
Example test to display error event for invalid annotation name
12e74ff
Merge branch 'main' of github.com:nginxinc/kubernetes-ingress
6b738f8
Remove validation test
fa2fd08
Merge branch 'main' of github.com:nginxinc/kubernetes-ingress
e66e5da
Merge branch 'main' of github.com:nginxinc/kubernetes-ingress
554292e
Merge branch 'main' of github.com:nginxinc/kubernetes-ingress
8e0ae97
Merge branch 'main' of github.com:nginxinc/kubernetes-ingress
92882bf
Merge branch 'main' of github.com:nginxinc/kubernetes-ingress
1ada9c1
Merge branch 'main' of github.com:nginxinc/kubernetes-ingress
c137caa
Merge branch 'main' of github.com:nginxinc/kubernetes-ingress
0b8d855
Merge branch 'main' of github.com:nginxinc/kubernetes-ingress
acf1821
Merge branch 'main' of github.com:nginxinc/kubernetes-ingress
0b80f9b
Merge branch 'main' of github.com:nginxinc/kubernetes-ingress
4c9786f
Merge branch 'main' of github.com:nginxinc/kubernetes-ingress
e1ceec5
Merge branch 'main' of github.com:nginxinc/kubernetes-ingress
2ad9078
Merge branch 'main' of github.com:nginxinc/kubernetes-ingress
4dc4dae
Merge branch 'main' of github.com:nginxinc/kubernetes-ingress
5fba901
Merge branch 'main' of github.com:nginxinc/kubernetes-ingress
ad92100
Add informer factory for secrets
28cbb52
@github-actions github-actions bot added the enhancement Pull requests for new features/feature enhancements label Sep 22, 2022
@github-actions github-actions bot added the tests Pull requests that update tests label Sep 23, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2022 •
edited
Loading

Codecov Report

Merging #3088 (7f3454a) into main (17aad37) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

❗ Current head 7f3454a differs from pull request most recent head 4175308. Consider uploading reports for the commit 4175308 to get more accurate results

@@            Coverage Diff             @@
##             main    #3088      +/-   ##
==========================================
- Coverage   52.29%   52.23%   -0.07%     
==========================================
  Files          58       58              
  Lines       16006    16030      +24     
==========================================
+ Hits         8371     8373       +2     
- Misses       7356     7380      +24     
+ Partials      279      277       -2
Impacted Files Coverage Δ
internal/k8s/controller.go 11.03% <0.00%> (-0.07%) ⬇️
internal/k8s/handlers.go 6.81% <0.00%> (-0.02%) ⬇️
internal/k8s/validation.go 92.08% <0.00%> (-1.24%) ⬇️
...ternal/k8s/appprotect/app_protect_configuration.go 86.16% <0.00%> (-0.58%) ⬇️
internal/k8s/configuration.go 95.76% <0.00%> (+0.36%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shaun-nx shaun-nx marked this pull request as ready for review September 26, 2022 09:18
vepatel
vepatel requested changes Sep 26, 2022
View reviewed changes
Copy link
Contributor

@vepatel vepatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shaun-nx can you please mark these test as @pytest.mark.ingresses as secret isn't valid selector in pipeline so these won't be triggered

@shaun-nx shaun-nx requested a review from vepatel September 26, 2022 10:27
@shaun-nx shaun-nx merged commit 2a20c7d into main Sep 26, 2022
@shaun-nx shaun-nx deleted the feat/ignore-helm-secrets branch September 26, 2022 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ciarams87 ciarams87 ciarams87 approved these changes

@vepatel vepatel vepatel approved these changes

@haywoodsh haywoodsh Awaiting requested review from haywoodsh

@jjngx jjngx Awaiting requested review from jjngx

Assignees
No one assigned
Labels
enhancement Pull requests for new features/feature enhancements tests Pull requests that update tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shaun-nx @codecov-commenter @ciarams87 @vepatel