Helm Chart: Add annotations to the service account in the Helm chart #3065
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add annotations to pass with helm chart values.
jasonwilliams14
suggested changes
Sep 20, 2022
|
@jasonwilliams14 |
|
@0m1xa if you test it with |
lucacome
reviewed
Sep 21, 2022
Revert includeYear: false
lucacome
reviewed
Sep 27, 2022
Codecov Report
@@ Coverage Diff @@
## main #3065 +/- ##
==========================================
- Coverage 52.29% 52.28% -0.01%
==========================================
Files 58 58
Lines 15995 16006 +11
==========================================
+ Hits 8364 8369 +5
- Misses 7352 7358 +6
Partials 279 279
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
lucacome
reviewed
Oct 11, 2022
Co-authored-by: Luca Comellini <luca.com@gmail.com>
Co-authored-by: Luca Comellini <luca.com@gmail.com>
Co-authored-by: Luca Comellini <luca.com@gmail.com>
lucacome
approved these changes
Oct 21, 2022
coolbry95
pushed a commit
to coolbry95/kubernetes-ingress
that referenced
this pull request
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add annotations to pass with helm chart values.
Proposed changes
Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to that issue here in this description (not in the title of the PR).
The main idea is to have the ability to provide annotations to the service account.
It may be useful in many cases.
For example, according to this documentation, the service account should have the proper annotation when using the ingress controller with AWS Marketplace.
Before this PR it was not possible to specify this annotation with the helm chart.
Checklist
Before creating a PR, run through this checklist and mark each as complete.