Fix Helm Chart labels and templates. Move version update to labels #3606
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #3606 +/- ##
==========================================
- Coverage 52.26% 52.24% -0.02%
==========================================
Files 59 59
Lines 16873 16873
==========================================
- Hits 8818 8816 -2
- Misses 7760 7762 +2
Partials 295 295
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
41ab37d to
3535829
Compare
38ea760 to
9041aa1
Compare
There was a problem hiding this comment.
When I try this locally, the version labels don't update, and I get the following in the logs:
Error updating pod with labels: Pod "my-chart-nginx-ingress-controller-75c4fc6d5d-fxl7l" is invalid: [metadata.labels: Invalid value: ""3.0.0-SNAPSHOT-dda91a4"": a valid label must be an empty string or consist of alphanumeric characters, '-', '' or '.', and must start and end with an alphanumeric character (e.g. 'MyValue', or 'my_value', or '12345', regex used for validation is '(([A-Za-z0-9][-A-Za-z0-9.])?[A-Za-z0-9])?'), metadata.labels: Invalid value: ""1.23.2 (nginx-plus-r28)"": a valid label must be an empty string or consist of alphanumeric characters, '-', '' or '.', and must start and end with an alphanumeric character (e.g. 'MyValue', or 'my_value', or '12345', regex used for validation is '(([A-Za-z0-9][-A-Za-z0-9.])?[A-Za-z0-9])?')]
dda91a4 to
7665779
Compare
|
Thanks for catching this @ciarams87 ! I was doing some tests with quoting the versions and apparently, it was double quoting the string now. I've fixed it. |
"app.kubernetes.io/version" and "app.nginx.org/version" should be labels and not annotations. This also fixes name generation for the Helm Chart and adds selector labels.
ab9d924 to
088c150
Compare
app.kubernetes.io/versionandapp.nginx.org/versionshould be labels and not annotations.This also fixes name generation for the Helm Chart and adds selector labels.
Removed unnecessary names.