Skip to content

Update keyCache path for JWKs to avoid conflict with OIDC #3583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 27, 2023

Conversation

shaun-nx
Copy link
Contributor

@shaun-nx shaun-nx commented Feb 23, 2023

Proposed changes

This update resolves an issue that causes the keyCache directive from OIDC to collide with the keyCache directive used by JWKs.

Resolves this reported error

nginx: [emerg] the same path name "/var/cache/nginx/jwk" used in /etc/nginx/oidc/oidc_common.conf:17 and in /etc/nginx/conf.d/vs_default_webapp.conf:33

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added the bug An issue reporting a potential bug label Feb 23, 2023
@shaun-nx shaun-nx requested a review from ciarams87 February 23, 2023 16:01
@shaun-nx shaun-nx marked this pull request as ready for review February 23, 2023 16:01
@shaun-nx shaun-nx requested a review from a team as a code owner February 23, 2023 16:01
@shaun-nx shaun-nx requested a review from lucacome February 23, 2023 17:04
@shaun-nx shaun-nx merged commit debbe94 into main Feb 27, 2023
@shaun-nx shaun-nx deleted the bug/duplicateKeyCacheDir branch February 27, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue reporting a potential bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants