-
Notifications
You must be signed in to change notification settings - Fork 2k
App Policy Bundle #3560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App Policy Bundle #3560
Conversation
Looks good! Will the docs and automated tests be included in this PR? |
Not at the moment. Docs and examples will be added when we can generate a correct bundle. Generating policy bundles that are compatible with a NIC version is outside of the scope of this story. |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #3560 +/- ##
==========================================
+ Coverage 52.26% 52.29% +0.03%
==========================================
Files 59 59
Lines 16834 16849 +15
==========================================
+ Hits 8799 8812 +13
- Misses 7738 7740 +2
Partials 297 297
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Proposed changes
This PR introduces new functionality for NIC with App Protect. Users can provide app protect policy bundles on a mounted volume.
Introduced updates:
/etc/nginx/waf/bundles/
deployment.yaml
must include mounted volume, for example:Checklist
Before creating a PR, run through this checklist and mark each as complete.