Add missing OSS internal routes #3481
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During testing a bug was found that prevented NSM to egress through NIC OSS. The root cause of the bug was found to be a few missing configuration blocks in the OSS NIC template files. This adds in the server blocks necessary for internal routes to function as expected.
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #3481 +/- ##
==========================================
+ Coverage 51.95% 51.97% +0.01%
==========================================
Files 60 60
Lines 16797 16811 +14
==========================================
+ Hits 8727 8737 +10
- Misses 7775 7777 +2
- Partials 295 297 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
sjberman
approved these changes
Jan 25, 2023
lucacome
suggested changes
Jan 25, 2023
add if not .DisableIPV6 check for listening on 443 Co-authored-by: Luca Comellini <luca.com@gmail.com> Signed-off-by: Chase Kiefer <112438922+chase-kiefer@users.noreply.github.com>
add $proxyOrGRPC formatting from review feedback Co-authored-by: Luca Comellini <luca.com@gmail.com> Signed-off-by: Chase Kiefer <112438922+chase-kiefer@users.noreply.github.com>
lucacome
approved these changes
Jan 25, 2023
jasonwilliams14
approved these changes
Jan 25, 2023
lucacome
pushed a commit
that referenced
this pull request
Jan 25, 2023
During testing a bug was found that prevented NSM to egress through NIC OSS. The root cause of the bug was found to be a few missing configuration blocks in the OSS NIC template files. This adds in the server blocks necessary for internal routes to function as expected. (cherry picked from commit 21f5377)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
While enabling the OSS version of Kubernetes Ingress to integrate with NSM, the additional templates for internal routes were forgotten. This allows the OSS ingress templating to configure ingress/egress for NSM.
Checklist
Before creating a PR, run through this checklist and mark each as complete.