Make the resource comparison more informative in case of an error #2273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2273 +/- ##
==========================================
- Coverage 53.39% 53.38% -0.01%
==========================================
Files 43 43
Lines 13412 13412
==========================================
- Hits 7161 7160 -1
Misses 6022 6022
- Partials 229 230 +1
Continue to review full report at Codecov.
|
soneillf5
approved these changes
Dec 14, 2021
9a2fba4 to
1f9d1aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
In some rare cases, if an error occurred during comparison resources, this error might be overwritten by a less informative message "Error, spec has unexpected format". I think that giving more precisive information could help DevOps people to find the source of the error faster.
Checklist
Before creating a PR, run through this checklist and mark each as complete.