Skip to content

feat: Support healthchecks in gRPC upstreams #2178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 18, 2021
Merged

feat: Support healthchecks in gRPC upstreams #2178

merged 1 commit into from
Nov 18, 2021

Conversation

ciarams87
Copy link
Contributor

Proposed changes

Support healthchecks in gRPC upstreams. This also adds support for configuring grpc_status and grpc_service on health checks where the upstream is gRPC.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@github-actions github-actions bot added documentation Pull requests/issues for documentation enhancement Pull requests for new features/feature enhancements labels Nov 12, 2021
@ciarams87 ciarams87 force-pushed the feat/grpc-health-checks branch 2 times, most recently from 4a7a9cd to 50090b8 Compare November 12, 2021 20:43
pleshakov
pleshakov reviewed Nov 13, 2021
View reviewed changes
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ciarams87 Please see my comments and suggestions

@nginx-bot nginx-bot force-pushed the feat/grpc-health-checks branch 4 times, most recently from 7533680 to 0a6bca7 Compare November 16, 2021 09:13
@ciarams87 ciarams87 force-pushed the feat/grpc-health-checks branch 3 times, most recently from 40193ae to efeac22 Compare November 16, 2021 16:21
pleshakov
pleshakov reviewed Nov 16, 2021
View reviewed changes
@nginx-bot nginx-bot force-pushed the feat/grpc-health-checks branch from efeac22 to c41890d Compare November 16, 2021 23:42
@ciarams87 ciarams87 force-pushed the feat/grpc-health-checks branch from c41890d to 3334c49 Compare November 17, 2021 14:35
pleshakov
pleshakov approved these changes Nov 18, 2021
View reviewed changes
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ciarams87 ciarams87 force-pushed the feat/grpc-health-checks branch from 3334c49 to 8dc9864 Compare November 18, 2021 09:41
@nginx-bot nginx-bot force-pushed the feat/grpc-health-checks branch from 8dc9864 to 8d89f2e Compare November 18, 2021 15:23
@ciarams87 ciarams87 force-pushed the feat/grpc-health-checks branch from 8d89f2e to 256088a Compare November 18, 2021 16:03
@ciarams87 ciarams87 merged commit 3787d34 into master Nov 18, 2021
@ciarams87 ciarams87 deleted the feat/grpc-health-checks branch November 18, 2021 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pleshakov pleshakov pleshakov approved these changes

@soneillf5 soneillf5 soneillf5 approved these changes

@lucacome lucacome Awaiting requested review from lucacome

@vepatel vepatel Awaiting requested review from vepatel

Assignees
No one assigned
Labels
documentation Pull requests/issues for documentation enhancement Pull requests for new features/feature enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ciarams87 @pleshakov @soneillf5