Add ServiceMonitor to Helm Chart #2831
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit 3765c38 Merge: 8da9a9c 84cf0d2 Author: araineUnity <77511580+araineUnity@users.noreply.github.com> Date: Thu Jul 7 14:40:49 2022 -0400 Merge branch 'add-servicemonitor' of ssh://github.com/araineUnity/kubernetes-ingress into add-servicemonitor commit 8da9a9c Merge: d743ea0 8ec6e2f Author: araineUnity <77511580+araineUnity@users.noreply.github.com> Date: Thu Jul 7 14:40:45 2022 -0400 Merge branch 'main' into add-servicemonitor commit 84cf0d2 Merge: d743ea0 8ec6e2f Author: araineUnity <77511580+araineUnity@users.noreply.github.com> Date: Thu Jul 7 14:40:18 2022 -0400 Merge branch 'nginxinc:main' into add-servicemonitor commit d743ea0 Author: araineUnity <77511580+araineUnity@users.noreply.github.com> Date: Thu Jul 7 14:39:06 2022 -0400 Added create flag for controller.serviceMonitor. commit 4b8f8fd Author: araineUnity <77511580+araineUnity@users.noreply.github.com> Date: Thu Jul 7 14:35:45 2022 -0400 Added create flag wrapping for the template. commit 02c5690 Author: araineUnity <77511580+araineUnity@users.noreply.github.com> Date: Wed Jun 1 16:08:08 2022 -0400 Add descriptions of new values for ServiceMonitor in the documentation. Clarify naming of matchLabels value. commit 1844f1f Author: araineUnity <77511580+araineUnity@users.noreply.github.com> Date: Wed Jun 1 15:51:37 2022 -0400 Add service monitor definition to the Helm charts for deployment.
Codecov Report
@@ Coverage Diff @@
## main #2831 +/- ##
=======================================
Coverage 53.02% 53.02%
=======================================
Files 58 58
Lines 15641 15641
=======================================
Hits 8294 8294
Misses 7068 7068
Partials 279 279 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
lucacome
reviewed
Jul 11, 2022
deployments/helm-chart/templates/controller-servicemonitor.yaml
Outdated
Show resolved
Hide resolved
…Unity/kubernetes-ingress into add-servicemonitor-resource
lucacome
reviewed
Jul 13, 2022
lucacome
approved these changes
Jul 13, 2022
|
@ciarams87 is this something you'd please be able to review and approve so it gets merged into |
@ciarams87 or @shaun-nx , any feedback on this, or if possible, an approval? :) Thanks! |
jjngx
approved these changes
Jul 25, 2022
|
@araineUnity @unitygilles sorry for the delay, merging now. |
|
@araineUnity I think the default value for (cc @lucacome) |
|
thanks for catching this @centromere I added the change to #3113 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR addresses issue 2830, adding the ServiceMonitor template to the basic helm-chart for kubernetes-ingress. This would by default be inactive, only enabled if
controller.serviceMonitor.createis set.Checklist