Skip to content

Add additional unit tests to confirm special characters can't be used in the lb-method annotation #2742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 8, 2022

Conversation

shaun-nx
Copy link
Contributor

@shaun-nx shaun-nx commented Jun 7, 2022

Proposed changes

This change adds additional unit tests to confirm that special characters such as {, } and $ are not allowed

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added the enhancement Pull requests for new features/feature enhancements label Jun 7, 2022
@shaun-nx shaun-nx changed the title Feature/lb method validation Add additional unit tests to confirm special characters can't be used in the lb-method annotation Jun 7, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #2742 (babffe0) into main (2723d04) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2742      +/-   ##
==========================================
- Coverage   53.52%   53.51%   -0.01%     
==========================================
  Files          52       52              
  Lines       14764    14764              
==========================================
- Hits         7902     7901       -1     
  Misses       6599     6599              
- Partials      263      264       +1     
Impacted Files Coverage Δ
internal/k8s/configuration.go 95.47% <0.00%> (-0.39%) ⬇️
internal/k8s/validation.go 99.04% <0.00%> (+0.95%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@shaun-nx shaun-nx merged commit a077ac4 into main Jun 8, 2022
@shaun-nx shaun-nx deleted the feature/lb-method-validation branch June 8, 2022 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Pull requests for new features/feature enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants