Skip to content

AP: log-conf escaping chars #2691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2022
Merged

AP: log-conf escaping chars #2691

merged 1 commit into from
May 27, 2022

Conversation

rafwegv
Copy link
Contributor

@rafwegv rafwegv commented May 18, 2022

Proposed changes

Add fields related to security log formatting missing from the logconf CRD.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@rafwegv rafwegv requested review from ciarams87 and lucacome May 18, 2022 08:23
@rafwegv rafwegv self-assigned this May 18, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 18, 2022

Codecov Report

Merging #2691 (691e3ba) into main (5568e1f) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2691      +/-   ##
==========================================
- Coverage   53.49%   53.46%   -0.03%     
==========================================
  Files          52       52              
  Lines       14754    14754              
==========================================
- Hits         7892     7888       -4     
- Misses       6599     6601       +2     
- Partials      263      265       +2     
Impacted Files Coverage Δ
internal/k8s/configuration.go 95.47% <0.00%> (-0.39%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@lucacome lucacome linked an issue May 27, 2022 that may be closed by this pull request
@rafwegv rafwegv force-pushed the ap-log-escaping-chars branch from 322badd to 691e3ba Compare May 27, 2022 11:45
@ciarams87 ciarams87 merged commit 6611a9b into main May 27, 2022
@ciarams87 ciarams87 deleted the ap-log-escaping-chars branch May 27, 2022 13:50
@ciarams87 ciarams87 added this to the v2.3.0 milestone Jun 30, 2022
@ciarams87 ciarams87 added enhancement Pull requests for new features/feature enhancements labels Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Pull requests for new features/feature enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for escaping chars in APLogConf CRD
4 participants