Skip to content

allow configuring topologySpreadConstraints in Helm chart #2625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 31, 2022
Merged

allow configuring topologySpreadConstraints in Helm chart #2625

merged 1 commit into from
May 31, 2022

Conversation

kdomanski
Copy link
Contributor

@kdomanski kdomanski commented Apr 25, 2022 •
edited
Loading

Proposed changes

This allows a user of the Helm chart to add topologySpreadConstraints to the ingress pots, for example in order to ensure even distribution among availability zones.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Fixes #2629

@brianehlert
Copy link
Collaborator

For reviewers: https://kubernetes.io/docs/concepts/workloads/pods/pod-topology-spread-constraints/

@brianehlert brianehlert requested a review from lucacome April 25, 2022 14:46
@brianehlert
Copy link
Collaborator

Thanks @kdomanski
Could you please open a corresponding issue to help us track this PR?

@kdomanski
Copy link
Contributor Author

Done

@lucacome lucacome added the enhancement Pull requests for new features/feature enhancements label May 6, 2022
lucacome
lucacome suggested changes May 13, 2022
View reviewed changes
Copy link

@lucacome lucacome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kdomanski, thanks for the PR!

Would you mind adding the field for the DaemonSet as well?

Thanks

lucacome
lucacome reviewed May 13, 2022
View reviewed changes
@lucacome lucacome requested review from a team, jjngx and shaun-nx May 13, 2022 01:13
@codecov-commenter
Copy link

codecov-commenter commented May 14, 2022 •
edited
Loading

Codecov Report

Merging #2625 (6611a9b) into main (6611a9b) will not change coverage.
The diff coverage is n/a.

❗ Current head 6611a9b differs from pull request most recent head be62609. Consider uploading reports for the commit be62609 to get more accurate results

@@           Coverage Diff           @@
##             main    #2625   +/-   ##
=======================================
  Coverage   53.49%   53.49%           
=======================================
  Files          52       52           
  Lines       14754    14754           
=======================================
  Hits         7892     7892           
  Misses       6599     6599           
  Partials      263      263

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@kdomanski
Copy link
Contributor Author

Would you mind adding the field for the DaemonSet as well?

Done.

lucacome
lucacome approved these changes May 16, 2022
View reviewed changes
Copy link

@lucacome lucacome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kdomanski
Copy link
Contributor Author

@ciarams87 Hey, can I get a second review from you?

@lucacome
Copy link

@kdomanski can you rebase your branch with main?

@lucacome lucacome merged commit ed1a6f8 into nginx:main May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacome lucacome lucacome approved these changes

@jjngx jjngx jjngx approved these changes

@shaun-nx shaun-nx Awaiting requested review from shaun-nx shaun-nx was automatically assigned from nginxinc/kic

Assignees
No one assigned
Labels
enhancement Pull requests for new features/feature enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow configuring topologySpreadConstraints in Helm chart
5 participants
@kdomanski @brianehlert @codecov-commenter @lucacome @jjngx