Fix incorrect configuration and unexpected warnings about Secrets at the IC start #1654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit ensures that during the Ingress Controller start, Secret resources are processed before any of the resources that reference those Secrets. This prevents the IC from generating incorrect config and reporting warnings about missing Secrets. Note that the incorrect config and warnings were temporary and only occurred at the Ingress Controller start before the IC pod was considered ready (passed the readiness probe).
0b29e10 to
b94e8d0
Compare
|
rebased against master to fix the failing pipeline |
ciarams87
reviewed
Jun 15, 2021
Co-authored-by: Ciara Stacke <18287516+ciarams87@users.noreply.github.com>
ciarams87
approved these changes
Jun 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR ensures that during the Ingress Controller start, Secret resources are processed before any of the resources that reference those Secrets. This prevents the IC from generating incorrect config and reporting warnings about missing Secrets.
Note that the incorrect config and warnings were temporary and only occurred at the Ingress Controller start before the IC pod was considered ready (passed the readiness probe).
Fixes #1448