Skip to content

Parse NGINX Config for Valid NAP Syslog Server #1165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jul 17, 2025
Merged

Parse NGINX Config for Valid NAP Syslog Server #1165

merged 12 commits into from
Jul 17, 2025

Conversation

aphralG
Copy link
Contributor

@aphralG aphralG commented Jul 14, 2025

Proposed changes

  • If syslog server is not "localhost" or "127.0.0.0" ignore it
  • If a syslog server is not valid if multiple are configured try the next
  • Check if port is already in use
  • Only allow one syslog server for NAP

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@aphralG aphralG self-assigned this Jul 14, 2025
@aphralG aphralG requested a review from a team as a code owner July 14, 2025 10:46
@github-actions github-actions bot added the chore Pull requests for routine tasks label Jul 14, 2025
@aphralG aphralG added v3.x Issues and Pull Requests related to the major version v3 and removed chore Pull requests for routine tasks labels Jul 14, 2025
CVanF5
CVanF5 reviewed Jul 15, 2025
View reviewed changes
@github-actions github-actions bot added the chore Pull requests for routine tasks label Jul 16, 2025
@aphralG aphralG requested review from CVanF5 and craigell July 16, 2025 10:04
CVanF5
CVanF5 reviewed Jul 16, 2025
View reviewed changes
dhurley
dhurley reviewed Jul 16, 2025
View reviewed changes
dhurley
dhurley approved these changes Jul 17, 2025
View reviewed changes
@aphralG aphralG merged commit 8d7f74c into main Jul 17, 2025
25 checks passed
@aphralG aphralG deleted the add-support-multiple-nap-syslog-servers branch July 17, 2025 14:57
spencerugbo pushed a commit that referenced this pull request Jul 23, 2025
@aphralG @spencerugbo
Parse NGINX Config for Valid NAP Syslog Server (#1165)
e15d08c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhurley dhurley dhurley approved these changes

@CVanF5 CVanF5 CVanF5 approved these changes

@sean-breen sean-breen sean-breen approved these changes

@john-david3 john-david3 john-david3 approved these changes

@craigell craigell Awaiting requested review from craigell

Assignees

@aphralG aphralG

Labels
chore Pull requests for routine tasks v3.x Issues and Pull Requests related to the major version v3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@aphralG @dhurley @craigell @CVanF5 @sean-breen @john-david3