Add NAP paths to allowed directories #1163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aphralG
reviewed
Jul 11, 2025
internal/watcher/instance/nginx-app-protect-instance-watcher.go
Outdated
Show resolved
Hide resolved
john-david3
approved these changes
Jul 14, 2025
|
Think you need to update the |
|
Sorry can you update the |
dhurley
approved these changes
Jul 17, 2025
aphralG
approved these changes
Jul 18, 2025
spencerugbo
pushed a commit
that referenced
this pull request
Jul 23, 2025
* update go verion and golangci-lint * add paths for NAP upon instance discovery * use variable for NAP directory path * add paths when creating NAP instance * add nap paths by default, update agent config during upgrade * add nap by default * nap paths to default agent configuration * add back log message * only add config directory /etc/app_protect * update preinstall.sh * update default config * remove blank line --------- Co-authored-by: Aphral Griffin <a.griffin@f5.com>
Akshay2191
pushed a commit
that referenced
this pull request
Jul 23, 2025
* update go verion and golangci-lint * add paths for NAP upon instance discovery * use variable for NAP directory path * add paths when creating NAP instance * add nap paths by default, update agent config during upgrade * add nap by default * nap paths to default agent configuration * add back log message * only add config directory /etc/app_protect * update preinstall.sh * update default config * remove blank line --------- Co-authored-by: Aphral Griffin <a.griffin@f5.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Adds the NAP config directory
/etc/app-protectpaths to allowed directories by default.Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentmake install-toolsand have attached any dependency changes to this pull requestREADME.md)