Fix config format outputted by preinstall script #1149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sean-breen
approved these changes
Jun 30, 2025
john-david3
approved these changes
Jun 30, 2025
sean-breen
reviewed
Jun 30, 2025
| @@ -130,8 +130,13 @@ command: | |||
| skip_verify: false | |||
| " | |||
|
|
|||
| echo "$v3_config_contents" > "$v3_config_file" \ | |||
| || err_exit "Failed to write v3 config" | |||
| if [ -n "$( echo -e )" ]; then | |||
There was a problem hiding this comment.
Pretty sure this will only fail when echo itself isn't found
sh-3.2$ echo -e
-e
sh-3.2$ echo $?
0
sean-breen
reviewed
Jun 30, 2025
| || err_exit "Failed to write v3 config" | ||
| if [ -n "$( echo -e )" ]; then | ||
| echo "$v3_config_contents" > "$v3_config_file" \ | ||
| || err_exit "Failed to write v3 config" |
There was a problem hiding this comment.
I think this err_exit condition will never be executed since the echo won't fail even with empty string etc.
There was a problem hiding this comment.
sh-3.2$ echo "" > i_dont_exist
sh-3.2$ echo $?
0
aphralG
approved these changes
Jul 1, 2025
craigell
approved these changes
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fix config format outputted by preinstall script.
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentmake install-toolsand have attached any dependency changes to this pull requestREADME.md)