Skip to content

QUIC: fixed a typo. #638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2025
Merged

QUIC: fixed a typo. #638

merged 1 commit into from
Apr 23, 2025

Conversation

nandsky
Copy link
Contributor

@nandsky nandsky commented Apr 18, 2025

Based on Nginx coding style, MGX_QUIC_CUBIC_C is corrected to NGX_QUIC_CUBIC_C.

@arut
Copy link
Contributor

arut commented Apr 22, 2025

@nandsky thanks for the patch. Looks good. Please add a period at the end of the commit log.

@pluknet
Copy link
Contributor

pluknet commented Apr 22, 2025

Please follow the established style.
As a rule of thump, you can look at previous commit logs.

So, it might look as follows:

QUIC: fixed a typo.

@nandsky nandsky changed the title QUIC: Fixed a typo QUIC: fixed a typo. Apr 23, 2025
@nandsky
Copy link
Contributor Author

nandsky commented Apr 23, 2025

@arut @pluknet thanks and I have addressed the review comment.

@pluknet pluknet merged commit 9785db9 into nginx:master Apr 23, 2025
1 check passed
@Maryna-f5 Maryna-f5 added this to the nginx-1.27.6 milestone Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pluknet pluknet pluknet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
nginx-1.29.0
Development

Successfully merging this pull request may close these issues.
4 participants
@nandsky @arut @pluknet @Maryna-f5