Allowed square brackets with portless IPv6 address. #318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pluknet
reviewed
Nov 25, 2024
There was a problem hiding this comment.
The patch looks good.
Allowed square brackets with portless IPv6 address.
The text is misleading, IMHO.
For me, this reads primarily as of the listen directive.
As a reference, this format is also allowed by RFC 9110 for the "Host"
header, and by RFC 7239 for "Forwarded by/for".
I would mention foremost RFC 3986, referenced in both 9110 and 7239. Something like this:
: This format conforms to the RFC 3986 format.
Strictly speaking, RFC 9110 and 7239 have indirect relationship to ngx_parse_add_port consumers, such as proxy_bind and X-Forwarded-For, so probably it makes sense to omit them for brevity.
When client address is received, IPv6 address could be specified without square brackets and without port, as well as both with the brackets and port. The change allows IPv6 in square brackets and no port, which was previously considered an error. This format conforms to RFC 3986. The change also affects proxy_bind and friends.
69cabd1 to
7fc0266
Compare
pluknet
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In several places in nginx, when an address with an optional port is expected, IPv6 address could be specified without square brackets and without port, as well as both with the brackets and port. The change allows IPv6 in square brackets and no port, which was previously considered an error.
As a reference, this format is also allowed by RFC 9110 for the "Host" header, and by RFC 7239 for "Forwarded by/for".
The change affects headers parsing in
ngx_http_realip_module, as well asproxy_bindand friends.