Core: change TCP keepalive from ms to seconds on DragonFly BSD #258
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will look when time permits. |
dvershinin
approved these changes
Nov 2, 2024
1774a79 to
dd57c04
Compare
|
Thanks for the patch. |
pluknet
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
DragonFly BSD has changed the time unit for TCP keep-alive from milliseconds to seconds since 5.7 development patch 2, thus setting the keepalive options in milliseconds on DragonFlyBSD 5.8+ will cause the values to be magnified by a factor of a thousand.
Fix it by distinguishing the DragonFly BSD versions and use the proper time units accordingly.
Ref:
https://mailman.nginx.org/pipermail/nginx-devel/2013-July/003980.html
https://lists.dragonflybsd.org/pipermail/commits/2019-July/719125.html
https://github.com/DragonFlyBSD/DragonFlyBSD/blob/965b380e960908836b97aa034fa2753091e0172e/sys/sys/param.h#L207
https://www.dragonflybsd.org/release58/