Skip to content

fix(sf): fix invalid empty value of pathValue property #1099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 20, 2020
Merged

fix(sf): fix invalid empty value of pathValue property #1099

merged 1 commit into from
Dec 20, 2020

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented Dec 20, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@ng-alain-bot
Copy link
Contributor

ng-alain-bot commented Dec 20, 2020 •
edited
Loading

Preview is ready!

@codecov
Copy link

codecov bot commented Dec 20, 2020

Codecov Report

Merging #1099 (f84ff83) into master (8ae609c) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1099   +/-   ##
=======================================
  Coverage   96.42%   96.42%           
=======================================
  Files         237      237           
  Lines        7414     7414           
  Branches     1351     1351           
=======================================
  Hits         7149     7149           
  Misses        138      138           
  Partials      127      127
Impacted Files Coverage Δ
packages/form/src/model/form.property.ts 94.27% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ae609c...f84ff83. Read the comment docs.

@cipchk cipchk merged commit dad5ed0 into master Dec 20, 2020
@cipchk cipchk deleted the issues-1879 branch December 20, 2020 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sf.setvalue(null)和autocomplete值清空后formValueChange中的pathValue会取完整的表单数据, 没有取到当前字段的值
2 participants
@cipchk @ng-alain-bot