-
Notifications
You must be signed in to change notification settings - Fork 894
add module for btyper3 #3817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add module for btyper3 #3817
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small comments :p
channels: | ||
- conda-forge | ||
- bioconda | ||
- defaults |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- defaults |
""" | ||
|
||
stub: | ||
def args = task.ext.args ?: '' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
def args = task.ext.args ?: '' |
type: map | ||
description: | | ||
Groovy Map containing sample information | ||
e.g. `[ id:'test', single_end:false ]` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
e.g. `[ id:'test', single_end:false ]` | |
e.g. `[ id:'test' ]` |
Probably does not apply here?
type: map | ||
description: | | ||
Groovy Map containing sample information | ||
e.g. `[ id:'test', single_end:false ]` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
e.g. `[ id:'test', single_end:false ]` | |
e.g. `[ id:'test' ]` |
{ assert snapshot( | ||
process.out.tsv, | ||
process.out.versions | ||
).match() | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also assert whether the results folder is present? maybe even check the subfiles that are created in that folder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this file is not needed anymore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
run nf-core modules lint --fix
to bring this into the new format :)
Hey @rpetit3, are you planning to work on this? We are doing some nf-core cleaning and are trying to close PRs that nobody works on anymore - just to know if you plan to keep working on this one :) |
Closing due to inactivity. Feel free to reopen the PR if you (or anyone else) have some time to finish this. |
PR checklist
Closes #3816
versions.yml
file.label
PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware