Skip to content

Conversation

rpetit3
Copy link
Contributor

@rpetit3 rpetit3 commented Sep 7, 2023

PR checklist

Closes #3816

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware

@rpetit3 rpetit3 added the new module Adding a new module label Sep 7, 2023
Copy link
Contributor

@nvnieuwk nvnieuwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small comments :p

channels:
- conda-forge
- bioconda
- defaults
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- defaults

"""

stub:
def args = task.ext.args ?: ''
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def args = task.ext.args ?: ''

type: map
description: |
Groovy Map containing sample information
e.g. `[ id:'test', single_end:false ]`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
e.g. `[ id:'test', single_end:false ]`
e.g. `[ id:'test' ]`

Probably does not apply here?

type: map
description: |
Groovy Map containing sample information
e.g. `[ id:'test', single_end:false ]`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
e.g. `[ id:'test', single_end:false ]`
e.g. `[ id:'test' ]`

Comment on lines +26 to +30
{ assert snapshot(
process.out.tsv,
process.out.versions
).match()
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also assert whether the results folder is present? maybe even check the subfiles that are created in that folder.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this file is not needed anymore

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

run nf-core modules lint --fix to bring this into the new format :)

@luisas
Copy link
Contributor

luisas commented Mar 11, 2025

Hey @rpetit3, are you planning to work on this?

We are doing some nf-core cleaning and are trying to close PRs that nobody works on anymore - just to know if you plan to keep working on this one :)

@luisas luisas added awaiting-changes will be closed after 30 days awaiting-feedback will be closed after 30 days labels Mar 11, 2025
@SPPearce
Copy link
Contributor

SPPearce commented Jun 8, 2025

Closing due to inactivity. Feel free to reopen the PR if you (or anyone else) have some time to finish this.

@SPPearce SPPearce closed this Jun 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-changes will be closed after 30 days awaiting-feedback will be closed after 30 days new module Adding a new module
Projects
Development

Successfully merging this pull request may close these issues.

new module: Btyper3
5 participants