Skip to content

add module for shigeifinder #2523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 19, 2022
Merged

add module for shigeifinder #2523

merged 4 commits into from
Nov 19, 2022

Conversation

rpetit3
Copy link
Contributor

@rpetit3 rpetit3 commented Nov 18, 2022 •
edited
Loading

PR checklist

Closes #2522

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware

@rpetit3 rpetit3 added the new module Adding a new module label Nov 18, 2022
SPPearce
SPPearce reviewed Nov 18, 2022
View reviewed changes
SPPearce
SPPearce approved these changes Nov 19, 2022
View reviewed changes
Copy link
Contributor

@SPPearce SPPearce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go then.

@rpetit3
Copy link
Contributor Author

rpetit3 commented Nov 19, 2022

Thank you!

@rpetit3 rpetit3 merged commit daced79 into nf-core:master Nov 19, 2022
@rpetit3 rpetit3 deleted the rp3-add-shigeifinder branch November 19, 2022 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SPPearce SPPearce SPPearce approved these changes

Assignees
No one assigned
Labels
new module Adding a new module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

new module: shigeifinder
2 participants
@rpetit3 @SPPearce