Skip to content

Conversation

David-Development
Copy link
Member

No description provided.

Signed-off-by: David Luhmer <david-dev@live.de>
@David-Development
Copy link
Member Author

@tobiasKaminsky @stefan-niedermann I noticed that the API for the verifyMinVersion changed but in the corresponding MR I couldn't really find the motivation behind it nextcloud/Android-SingleSignOn#735.

What was the reason for the change? The docs contain an invalid example on how to use the API and I'm not sure if the changes in this MR are correct according to how I am supposed to use the API 😅

@stefan-niedermann
Copy link
Member

Hey @David-Development 👋
Background of the changes in the SSO lib was to be able to connect to branded Nextcloud files clients which use different account IDs. This was not possible until now without forking the SSO lib and adjusting the EFilesAppType enum, now the target Files App Type ID can be set by the 3rd party app in Application#onCreate dynamically.

While the changes have been implemented by @tobiasKaminsky I needed tsuch a feature personally too, so I support the changes :)

@David-Development David-Development merged commit bd9ba92 into master Feb 15, 2025
16 checks passed
@David-Development David-Development deleted the padding branch February 15, 2025 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants