Use one Glide instance per NewsListRecyclerAdapter #1410
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Unpublished <unpublished@gmx.net>
Signed-off-by: Unpublished <unpublished@gmx.net>
|
@DoHe Can you double check if this branch fixes the issue for you as well? |
|
@Unpublished yes, I can confirm this fixes the favion issues I was seeing 👍 |
|
@Unpublished Thank you for implementing this so quickly! Looks like a great solution to me. I'm glad that you were able to remove the static reference. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue mentioned in #1405 without each view having its own glide instance
Also fixes leaking context via static reference to FavIconHolder
More infos: