Add "remove podcast" in toolbar and "Downloaded podcasts" special folder #1273
Conversation
|
Wow! This is an awesome feature! I really like the idea of having a "folder" for all podcasts that are downloaded. Makes it much easier to keep track of them. Just a quick thought.. we need to make sure to keep articles with downloaded items around - even if they're marked as read. Otherwise they might be removed from the phones database (ref) in case the user has many unread articles. I'll try to do an more in depth review today/tomorrow! |
|
@r3tr0-git It's done, it just needs to be reviewed (and maybe changed depending on how the review goes of course). |
News-Android-App/src/main/java/de/luhmer/owncloudnewsreader/NewsReaderDetailFragment.java
Outdated
Show resolved
Hide resolved
News-Android-App/src/main/java/de/luhmer/owncloudnewsreader/NewsReaderDetailFragment.java
Outdated
Show resolved
Hide resolved
|
@mkanilsson Sorry - I think you have a few conflicts now since I did some refactoring in the sidebar. Once everything looks good from your side you can mark it as "Ready for review". Currently it's still marked as "Draft". |
This patch adds a Trash icon in the toolbar for podcasts that have downloaded media. Signed-off-by: Marcus Nilsson <marcus.nilsson@genarp.com>
Signed-off-by: Marcus Nilsson <marcus.nilsson@genarp.com>
This patch makes podcasts that are downloaded not get removed when cleaning up database when oversized. Signed-off-by: Marcus Nilsson <marcus.nilsson@genarp.com>
e6908c9 to
f8a9d56
Compare
|
I'm very sorry for the delay, I got a new job so I've been quite busy. Everything should be fixed now and should be able to merge cleanly. Hmm, it complains that all commits must be signed, which they are... |
|
@mkanilsson No worries, thank you for finishing this MR! And congrats to your new job! Looks great to me - I just noticed that there are a few strings that are not translated yet - I'll merge it already and add them as translations in a separate MR. |
This PR adds 1. a trashcan icon in the toolbar when in a podcast and 2. a special
Downloaded Podcastsin the sidebar.This is a draft because:
Once this is done, it will close #742
podcast.mp4