Get display number from the DIX layer rather than a global #364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Devel versions of the X server do not contain the global string variable 'display' in opaque.h. It has been replaced by the getter function dixGetDisplayName()
f2d3204 to
de43adc
Compare
|
@jsorg71 - are you happy with the way I'm detecting the getter function, or would you rather do a check against the Xorg version, when we know what it's going to be? |
|
I think that looks fine @matt335672 thanks and thanks @metux |
jsorg71
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #340
Fixes #362
Draft PR for now. It isn't clear that we need this yet, as the change which has precipitated this has not yet appeared in any mainline distros.Devel versions of the X server do not contain the global string variable 'display' in opaque.h. See #340 for more information.This commit works around that by extracting the required information from the DISPLAY variable.Edit: 2025-02-12 We've been provided with a new function in the DIX layer to get the display name. This PR uses that function if it is available
@jsorg71 - I'd appreciate your thoughts on this. I can't find a better way to do this at the moment. Would it be better to set a variable in sesman for the whole socket path do you think?
Also, it might be better to use the Xorg version to test for the getter function, as we do this elsewhere. At the moment this isn't possible, as we don't know what the version will be.