This repository was archived by the owner on Feb 16, 2024. It is now read-only.
Fixed TakeUntil to respect official definition: "discard any items em… #269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…itted by an Observable after a second Observable emits an item or terminates". Previously, TakeUntil() would only complete if an OnNext() was emitted on second observable, but not if an OnCompleted() was emitted.
EarMaster
pushed a commit
to EarMaster/UniRx
that referenced
this pull request
Jun 12, 2019
Fixed TakeUntil to respect official definition: "discard any items em…
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the definition of TakeUntil(): "discard any items emitted by an Observable after a second Observable emits an item or terminates".In current implementation, TakeUntil() will only complete if an OnNext() is emitted on second observable, but NOT if that observable completes.That can be very problematic, especially if your logic assumes and relies on the official definition.