This repository was archived by the owner on Feb 21, 2019. It is now read-only.
Return even classes without annotations when using parsePhp #10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I'm using
AnnotationsParser::parsePhp()
method to retrieve FQN of classes in php string, then instantiating those classes using something like$reflectionClass = new \ReflectionClass($className))
.However,
parsePhp()
won't return name of the classes if they don't have any annotation or at least anyuse
statement. This is quite limiting, as I want to read name of the class no mater if it has any annotations/use statements or not - the exact content of annotations could be checked later (with eg.AnnotationsParser::getAll($reflectionClass)
).Currently there is no way determining whether the file don't contain any class at all, or just class without annotations.
I prepared PoC that changed the behavior. I'm not sure if there is any reason for the current behavior or if this change would break something? If so, this behavior could be at least triggered optionally. What do you think?
Parsing this file with
parsePhp()
will result in null being returned:But this will return
['Foo\Bar' => ['use' => ['AbstractBar' => 'Baz\Ban\AbstractBar']]]
: