SessionExtension: don't set readAndClose if null #213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Session class throws exception if session is started and option read_and_close is set. SessionExtension breaks compatibility with other session implementations (in case they already started the session) by always setting that option (to default value).
59f402a to
32af756
Compare
ba7eba8 to
7774190
Compare
c6e0524 to
788ddc4
Compare
0f24022 to
ebdb825
Compare
684be2b to
2a0c595
Compare
|
Thanks |
dg
pushed a commit
that referenced
this pull request
Mar 18, 2023
Session class throws exception if session is started and option read_and_close is set. SessionExtension breaks compatibility with other session implementations (in case they already started the session) by always setting that option (to default value).
dg
pushed a commit
that referenced
this pull request
Mar 18, 2023
Session class throws exception if session is started and option read_and_close is set. SessionExtension breaks compatibility with other session implementations (in case they already started the session) by always setting that option (to default value).
dg
pushed a commit
that referenced
this pull request
Mar 18, 2023
Session class throws exception if session is started and option read_and_close is set. SessionExtension breaks compatibility with other session implementations (in case they already started the session) by always setting that option (to default value).
dg
pushed a commit
that referenced
this pull request
Mar 18, 2023
Session class throws exception if session is started and option read_and_close is set. SessionExtension breaks compatibility with other session implementations (in case they already started the session) by always setting that option (to default value).
dg
pushed a commit
that referenced
this pull request
Mar 18, 2023
Session class throws exception if session is started and option read_and_close is set. SessionExtension breaks compatibility with other session implementations (in case they already started the session) by always setting that option (to default value).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Session class throws exception if session is started and option read_and_close is set.
http/src/Http/Session.php
Lines 401 to 404 in 0679e7c
SessionExtension breaks compatibility with other session implementations (in case they already started the session) by always setting that option (to default value).
http/src/Bridges/HttpDI/SessionExtension.php
Line 40 in 0679e7c