Skip to content

setCookie() expire type issue #233

@lukaspijak

Description

@lukaspijak

Version: 3.3.0

Bug Description

Hello @dg,

in interface Nette\Http\IResponse you add to setCookie method to expiration parameter union type ?int. But in documentation you can use string date representation. For example in Nette\Bridges\SecurityHttp\CookieStorage has property $cookieExpiration union type ?string, but on line 51 you use ?string in setCookie, it can cause type error.

Will it be possible to specify expiration using string|int|null in the future, or will everything be refactored to ?int?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions