Skip to content

Conversation

mr-vara
Copy link

@mr-vara mr-vara commented Feb 28, 2025

Proposed changes

This PR removes coming soon test exclusion in cypress config

Type of Change

Production

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update
  • Refactoring / housekeeping (changes to files not directly related to functionality)

Development

  • Tests
  • Dependency update
  • Environment update / refactoring
  • Documentation Update

Video

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Copy link

cypress bot commented Feb 28, 2025

Web Plugin    Run #1215

Run Properties:  status check failed Failed #1215  •  git commit fd55ece31c ℹ️: Merge 7c027f898c10368e95f3884b44f4ab824ae4a076 into 85a6afc3498a5da21b4fbd7298dd...
Project Web Plugin
Branch Review press11-144-undo-excluding-tests
Run status status check failed Failed #1215
Run duration 06m 39s
Commit git commit fd55ece31c ℹ️: Merge 7c027f898c10368e95f3884b44f4ab824ae4a076 into 85a6afc3498a5da21b4fbd7298dd...
Committer Vara
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 1
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 70
View all changes introduced in this branch ↗︎

Tests for review

Failed  vendor/newfold-labs/wp-module-coming-soon/tests/cypress/integration/coming-soon.cy.js • 1 failed test

View Output Video

Test Artifacts
Coming Soon > Has Coming Soon Section on Home Test Replay Screenshots Video
Flakiness  tests/cypress/integration/help.cy.js • 1 flaky test

View Output Video

Test Artifacts
Help Page > Is Accessible Test Replay Screenshots Video

@circlecube
Copy link
Member

The coming soon tests are skipped in this plugin because it does not contain the e-commerce module. Not ideal, but for whatever reason, e-commerce has coming-soon components in it, which change the functionality. The current tests in the coming-soon module expect the e-commerce module to be in place, but since it is not in this plugin, the plugin has its own legacy coming-soon test that is run.

Ideally, the coming-soon elements can be moved out of e-commerce and into coming soon, so it is consistent and independent of other modules, but we're not quite there yet. Once we get to that point, we should be able to do as proposed here and stop skipping the coming soon tests and remove the plugin level coming soon test too. If coming soon functionality changes so that the plugin test fails, it can be updated here at the plugin level during a release cycle.

@circlecube circlecube closed this Mar 7, 2025
@circlecube
Copy link
Member

This does seem to be causing some intermittent issues when testing the plugin though. See PRESS0-2464 for an example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants