Skip to content

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jul 9, 2025

Changes in this pull request

  • Bumped version from 4.4.0 to 4.4.1
  • ℹ️ Notice: post-set-version script not defined.
  • ✅ Ran npm script: build
  • ✅ Ran composer script: i18n

Merged PRs since last release

Generated automatically by CI workflow (see prep-release workflow).

dependabot bot and others added 16 commits July 7, 2025 10:10
Bumps [newfold-labs/wp-module-hosting](https://github.com/newfold-labs/wp-module-hosting) from 1.1.2 to 1.1.3.
- [Release notes](https://github.com/newfold-labs/wp-module-hosting/releases)
- [Commits](newfold-labs/wp-module-hosting@1.1.2...1.1.3)

---
updated-dependencies:
- dependency-name: newfold-labs/wp-module-hosting
  dependency-version: 1.1.3
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
- Add StagingRedirect component to redirect /staging to /wp-admin/admin.php?page=nfd-staging
…tools-blank-page

add redirect for specific route
…/newfold-labs/wp-module-hosting-1.1.3

Composer(deps): Bump newfold-labs/wp-module-hosting from 1.1.2 to 1.1.3
Bumps [newfold-labs/wp-module-performance](https://github.com/newfold-labs/wp-module-performance) from 3.1.6 to 3.2.6.
- [Release notes](https://github.com/newfold-labs/wp-module-performance/releases)
- [Commits](newfold-labs/wp-module-performance@3.1.6...3.2.6)

---
updated-dependencies:
- dependency-name: newfold-labs/wp-module-performance
  dependency-version: 3.2.6
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
…/newfold-labs/wp-module-performance-3.2.6

Composer(deps): Bump newfold-labs/wp-module-performance from 3.1.6 to 3.2.6
Bumps [newfold-labs/wp-module-onboarding](https://github.com/newfold-labs/wp-module-onboarding) from 3.0.1 to 3.0.2.
- [Release notes](https://github.com/newfold-labs/wp-module-onboarding/releases)
- [Commits](newfold-labs/wp-module-onboarding@3.0.1...3.0.2)

---
updated-dependencies:
- dependency-name: newfold-labs/wp-module-onboarding
  dependency-version: 3.0.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
…/newfold-labs/wp-module-onboarding-3.0.2

Composer(deps): Bump newfold-labs/wp-module-onboarding from 3.0.1 to 3.0.2
Add more redirects for legacy paths
@circlecube circlecube closed this Jul 9, 2025
@circlecube circlecube reopened this Jul 9, 2025
@circlecube

This comment was marked as outdated.

@circlecube

This comment was marked as outdated.

wpalani
wpalani previously approved these changes Jul 10, 2025
circlecube and others added 2 commits July 10, 2025 10:29
Bumps [newfold-labs/wp-module-onboarding](https://github.com/newfold-labs/wp-module-onboarding) from 3.0.2 to 3.0.3.
- [Release notes](https://github.com/newfold-labs/wp-module-onboarding/releases)
- [Commits](newfold-labs/wp-module-onboarding@3.0.2...3.0.3)

---
updated-dependencies:
- dependency-name: newfold-labs/wp-module-onboarding
  dependency-version: 3.0.3
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@circlecube circlecube added this to the July 16, 2025 Release milestone Jul 10, 2025
…/newfold-labs/wp-module-onboarding-3.0.3

Composer(deps): Bump newfold-labs/wp-module-onboarding from 3.0.2 to 3.0.3
* develop:
  Composer(deps): Bump newfold-labs/wp-module-onboarding
…omment-for-build

* update/workflow-triggers-and-concurrency:
  update release PR workflow triggers and concurrency
Add persistent PR comment with link to build
…d-concurrency

update release PR workflow triggers and concurrency
* develop:
  yml linting
  update formatting again
  try with less indentation
  try another PR comment formatting
  lint whitespace fix and fix markdown
  update comment body with friendly fomatting
  use artifact action output for artifact link
  update comment link text
  add persistent PR comment with link to build
  update release PR workflow triggers and concurrency

# Conflicts:
#	.github/workflows/upload-artifact-on-push.yml
Copy link
Contributor Author

github-actions bot commented Jul 14, 2025

Latest Plugin Build

⬇️ Download build artifact: https://github.com/newfold-labs/wp-plugin-bluehost/actions/runs/16331011804/artifacts/3549594086
🗂️ Built from: release/4.4.1
📦 Commit: 00996d4
📅 Date: 2025-07-16T21:47:22.560Z
🚀 Please download, test, and report any issues before merging. 🎉 This build includes the latest changes from this PR and was automatically generated by the GitHub Actions workflow. Any future commits will update this build.
Note: Artifacts expire after ~90 days

@circlecube
Copy link
Member

When I pulled the latest build from https://github.com/newfold-labs/wp-plugin-bluehost/actions/runs/16223367937?pr=399 for testing, it was missing the vendor/newfold-labs/wp-module-staging/lib/.staging file, which is core to the staging functionality. Just wanted to make sure this doesn’t go out without that file.

Took a while to make sense of this. I could see the file listed in the dist list here: https://github.com/newfold-labs/wp-plugin-bluehost/actions/runs/16270779442/job/45937588548#step:16:1045 but also, when I download the zip file I couldn't find the file either. It seems like the upload-artifact workflow was updated recently to ignore hidden files and our build on push workflow hasn't included the hidden staging file for a couple months. The goos news is that our release build workflow has continued to include this hidden file (since in that workflow we have a step that manually performs the zip, so the hidden file is included).

This was just a fault in the build workflow on push, and the actual release has been working still. I got the build workflow updated today to use the include-hidden-files flag in the action and the file is properly included, I checked the build to ensure no unexpected hidden files were incldued, but those are excluded properly via the disignore file already.

Copy link
Member

@arunshenoy99 arunshenoy99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a big fan of skipping tests, especially since I had pinged about https://github.com/newfold-labs/wp-module-migration/releases/tag/1.5.7 a while back, it fixes the migration onboarding redirect test issue. We missed unskipping it last time. That said, it should be fine as long as we remember to uncomment it later.

Copy link
Member

@arunshenoy99 arunshenoy99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also noticed that https://github.com/newfold-labs/wp-module-performance/releases/tag/3.2.8 hasn't been included. I had pinged about this too. It fixes a bug with link prefetching that was found in this release. Can we add it? @circlecube

@circlecube
Copy link
Member

@arunshenoy99 - We need to adhere to the release window to ensure quality and consistency. The module releases available when the release candidate is created are included in the release. While I appreciate that the module updates include useful bug fixes, unless they address a critical issue, they will be included in the next scheduled release (which is prepared immediately after this one is tagged).

Following this window is important because it gives the QA team the time they need to thoroughly test. Ideally, no module updates should be included unless it was tagged before the release window closed. We've seen recent issues in releases that didn't have ample time for QA tests.

@circlecube circlecube merged commit 320f926 into main Jul 17, 2025
38 of 44 checks passed
@circlecube circlecube deleted the release/4.4.1 branch July 17, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants