Skip to content

Onboarding v3 #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 2, 2025
Merged

Onboarding v3 #391

merged 4 commits into from
Jul 2, 2025

Conversation

wpalani
Copy link
Member

@wpalani wpalani commented Jul 2, 2025

Proposed changes

  • Bump Onboarding to v3 to pull in unified onboarding changes.
  • Bump Onboarding-Data to 1.2.12 needed by Onboarding v3
  • Skip Onboarding tests (tests will be added as fast-follow)

Type of Change

Production

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update
  • Refactoring / housekeeping (changes to files not directly related to functionality)

Development

  • Tests
  • Dependency update
  • Environment update / refactoring
  • Documentation Update

Video

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

circlecube
circlecube approved these changes Jul 2, 2025
View reviewed changes
Copy link
Member

@circlecube circlecube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 2 failing tests look to be some flaky tests that fail from time to time. Will investigate further in the RC if needed.

@circlecube circlecube merged commit 1e8cd24 into develop Jul 2, 2025
1 of 2 checks passed
@circlecube circlecube deleted the update/onboarding-v3 branch July 2, 2025 16:31
@github-actions github-actions bot mentioned this pull request Jul 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@circlecube circlecube circlecube approved these changes

@abhijitb abhijitb Awaiting requested review from abhijitb

@wpscholar wpscholar Awaiting requested review from wpscholar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wpalani @circlecube