Support pre and post i18n scripts #387
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Updates the translation workflow by removing the legacy WP i18n script, introducing pre- and post-i18n Composer tasks, and switching the GitHub action to a consolidated translations workflow.
- Refactors the
i18nnpm script to use Composer only - Adds
i18n-ci-preandi18n-ci-postscript groups incomposer.json - Points the auto-translate workflow at the new reusable-translations action
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Removed wpi18n addtextdomain from the i18n script |
| composer.json | Added i18n-ci-pre and i18n-ci-post script arrays |
| .github/workflows/auto-translate.yml | Updated reusable workflow to reusable-translations |
Comments suppressed due to low confidence (3)
package.json:83
- Update project documentation and remove the now-unused
wpi18ndependency or script references to keep setup instructions accurate.
"i18n": "composer run i18n",
composer.json:62
- Add entries for
i18n-ci-preandi18n-ci-postin thescripts-descriptionssection so CLI help output remains clear and complete.
"i18n-ci-pre": [
.github/workflows/auto-translate.yml:23
- Verify that the new
reusable-translations.ymlaction matches the inputs/outputs of the previous workflow, and update any documentation or mappings accordingly.
uses: newfold-labs/workflows/.github/workflows/reusable-translations.yml@main
circlecube
approved these changes
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Makes adjustments to deprecate the old-style translation workflow and account for newfold-labs/workflows#58.
Type of Change
Production
Development
Video
Checklist
Further comments