Add i18n-update workflow to automate the i18n source file generation and updation. #232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
desrosj
requested changes
May 19, 2025
Co-authored-by: Jonathan Desrosiers <359867+desrosj@users.noreply.github.com>
desrosj
approved these changes
May 24, 2025
There was a problem hiding this comment.
Looks good! I made a few small changes:
- Always use quotes for string values and prefer single quotes (explained over on another PR)
- Included the change to avoid hard coding the fallback value for
base_branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR adds i18n-update workflow to automate the i18n source files (.pot, .po, .php, .json) generation and updation.
See: https://jira.newfold.com/browse/PRESS11-154
Type of Change
Production
Development
Video
Checklist
Further comments