Skip to content

Conversation

circlecube
Copy link
Member

Proposed changes

Between #487 and adding the linkTracker the href check in our home test started having issues. This was on top of the a11y test issue from next steps. Now that those are all merged and updated in develop this final change should fix up the cypress test to pass with a ctb link or a wondercart link in the "Sales and Promotions" section of the home page.

Type of Change

Production

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update
  • Refactoring / housekeeping (changes to files not directly related to functionality)

Development

  • Tests
  • Dependency update
  • Environment update / refactoring
  • Documentation Update

Visual

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@circlecube circlecube self-assigned this Aug 13, 2025
@circlecube circlecube requested a review from a team August 13, 2025 19:46
@circlecube circlecube merged commit 24bb3c9 into develop Aug 13, 2025
2 of 3 checks passed
@circlecube circlecube deleted the fix/quick-link-test branch August 13, 2025 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants