Skip to content

Update sale promotion quick link PRESS0-3026 #487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 12, 2025
Merged

Update sale promotion quick link PRESS0-3026 #487

merged 5 commits into from
Aug 12, 2025

Conversation

circlecube
Copy link
Member

Proposed changes

Conditionally load the "Create a sale promotion" quick link either as a ctb link or an entitlement installer link.

This adds a ctbs.ecomFamily const to the runtime for access across the app, and also adds solution name and wondercart entitlement data when available to the runtime for use in the quick link.

See PRESS0-3026

Type of Change

Production

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update
  • Refactoring / housekeeping (changes to files not directly related to functionality)

Development

  • Tests
  • Dependency update
  • Environment update / refactoring
  • Documentation Update

Visual

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@circlecube
conditionally load the "Create a sale promotion" quick link as ctb li…
9476a5a 
…nk or entitlement installer link

this adds a ctbs.ecomFamily const to the runtime for access across the app
also adds solution name to runtime and pulls the wondercart entitlement data when available for use in the quick link
@circlecube
clean up data and use var for cleaner attribute insertion
b7a7a84
@circlecube
use isActive to place installer attrs and replace siteUrl in cta.url …
f7abca7 
…for button
@circlecube circlecube requested a review from a team August 8, 2025 13:37
@circlecube circlecube changed the base branch from main to develop August 8, 2025 13:37
@circlecube circlecube added this to the August 20, 2025 Release milestone Aug 11, 2025
@circlecube
Copy link
Member Author

The failing cypress test is an a11y issue from next-steps which should be fixed once this commit is merged/released: newfold-labs/wp-module-next-steps@791160d

@circlecube circlecube self-assigned this Aug 11, 2025
@circlecube circlecube merged commit e067935 into develop Aug 12, 2025
2 of 3 checks passed
@circlecube circlecube deleted the update/sale-promotion-quick-link_PRESS0-3026 branch August 12, 2025 18:39
@circlecube circlecube mentioned this pull request Aug 13, 2025
Merged
14 tasks
@github-actions github-actions bot mentioned this pull request Aug 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crodriguezbrito crodriguezbrito crodriguezbrito approved these changes

Assignees

@circlecube circlecube

Labels
None yet
Projects
None yet
Milestone
August 20, 2025 Release
Development

Successfully merging this pull request may close these issues.
2 participants
@circlecube @crodriguezbrito