update i18n workflow target branch #480
Conversation
There was a problem hiding this comment.
The actual code change in this PR looks great. 👍
I do have a few points that should be considered to ensure more consistency.
I'm fine with whatever Git flow works for the teams. Since I am not regularly involved with these repositories, I don't have any strong opinions. But I do think that we should enforce it for all plugin repos at the same time (and all module repos at the same time if we also want to follow that flow with those) and confirm that workflows and Dependabot configurations all expect develop to be the BASE branch for changes.
The primary branch for this repo is currently set to main. This has a few consequences:
- all new pull requests default to using
mainas the base branch - the default branch checked out when running
git cloneismain, which can easily result in someone building out a PR without the latest changes on accident. - All workflows that run on
schedulewill only ever run inmainand notdevelop
The last one has implications for workflows that run regularly, such as any workflows that aim to test the code base at an interval. It will only ever test the most recent release that was published.
Dependabot is currently configured to open pull requests for dependency updates with a BASE branch of develop. This means that until main is updated in preparation for the next release, these schedule events will have the potential to be utilizing outdated dependencies that have since been updated in develop. This is mainly important for any updates applied to workflow files that are applied that prevent disruptions as a result of service-level changes. While the brand plugins receive regular updates at this point in time, that may not always be the case, and may not be the case for other repositories that we extend this practice to (modules, workers, etc.).
Unless there are reasons that are not immediately apparent as to why develop should not be made the primary branch, I think we should also change the primary branch to make it easier to follow this flow, and make our scheduled testing workflows more
|
This makes sense to me. I can't think of any big reasons why we couldn't change the default branch to @wpscholar what do you think? @earnjam? |
|
I'll go ahead and merge this, but we should continue the discussion about the default branch and its impact on our workflows. @wpscholar is currently reimagining the release workflow and our dev workflow, and those points should be considered. But that discussion doesn't need to be a blocker to this PR. |
Proposed changes
In brand plugins, we do work on
developand only merge to main at release time, more a traditional git-flow approach than with modules. I think ideally we can targetdevelopinstead ofmainin this case for the i18n workflow. Open to thoughts, though.Type of Change
Production
Development
Visual
Checklist
Further comments