Fix vars not being available
#420
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where GitHub Actions variables defined using vars context were not accessible within workflow steps. The fix involves explicitly passing these variables as environment variables to make them available during step execution.
- Adds environment variable mappings for
varscontext variables in workflow steps - Ensures variables like
BASE_URL,PLUGIN_NAME,SERVER_USERNAME,SERVER_IP,SERVER_PATH, andSITE_URLare properly accessible - Resolves the performance cron workflow failure mentioned in the PR description
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.github/workflows/performance-cron.yml |
Adds BASE_URL environment variable mapping at job level |
.github/workflows/deploy-and-test.yml |
Adds environment variable mappings for server connection variables and site URL across multiple steps |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
circlecube
approved these changes
Jul 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Follow up to #176.
Variables defined for Actions re not immediately available within steps. They need to be explicitly passed as environment variables. See the GitHub docs for more information.
This was noticed because the performance cron workflow failed to complete successfully.
Type of Change
Production
Development
Visual
Checklist
Further comments