Skip to content

Conversation

circlecube
Copy link
Member

Proposed changes

This fixes the issue with missing tests.

Updates the workflow to use prefer-source instaed of prefer-dist.

Some modules recently added a .gitattributes which specifies ignoring tests dir when prefer-dist is used, so they were not being run. This looks like it was updated in moduls only in the past month or so, so as the PHP scaffolding PRs merged they were slowly being lost... This should fix it though!

Type of Change

Production

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update
  • Refactoring / housekeeping (changes to files not directly related to functionality)

Development

  • Tests
  • Dependency update
  • Environment update / refactoring
  • Documentation Update

Visual

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

some modules recently added a .gitattributes which specifies ignoring tests dir when prefer-dist is used
@circlecube circlecube requested review from arunshenoy99, wpalani and a team July 10, 2025 20:13
@circlecube circlecube merged commit fa8f10e into release/4.4.1 Jul 11, 2025
2 of 4 checks passed
@circlecube circlecube deleted the try/cypress-specPattern-for-top-level branch July 11, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants