update release PR workflow triggers and concurrency #403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…omment-for-build * update/workflow-triggers-and-concurrency: update release PR workflow triggers and concurrency
Add persistent PR comment with link to build
Latest Plugin Build⬇️ Download build artifact: |
wpalani
approved these changes
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This updates the workflow triggers.
Earlier, I tried using
workflow_runtypecompleteto trigger the workflows in a release branch. This trigger does work, but it doesn't associate the actions with the PR. Now I think the best course it to have the release prep workflow create a draft PR. Then once anyone marks the PR as ready for review, all the expected workflows will run as expected, this step makes more sense than trying to trigger workflows with workflows or as of lately, having to remember to close and reopen the PR to trigger the tests and push a dummy commit for a build (or manually trigger it and link it in a PR comment).I feel like the last step of marking the PR as ready for review is simple enough and won't be forgotten since it is easy to see a PR is still a draft.
See also the accompanying change in the reusable workflow: newfold-labs/workflows#65
This also updates the pull request trigger to synchronize in all cases (this is if a new commit is pushed to the PR branch), but removes the edit (which seems to only be when the PR description is edited - which we shouldn't trigger test or build jobs for that).
AND it updates the concurrency group. It simplifies it so that these workflows will no overlap (for push and PR sync) by using a consistent group name so both will resolve to the same branch name string (effectively), so they share the concurrency group.
Type of Change
Production
Development
Visual
Checklist
Further comments