Refine the options passed to the make-pot command
#304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the `node_modules` and `wordpress` directories to the exclude list for the `make-pot` command. Because WordPress is installed as a Composer dependency, the strings in WordPress Core could unintentionally be included in translation files when a text domain is missing. There should not be any strings that need translating in these directories, so excluding them saves time and is more performant.
There was a problem hiding this comment.
Pull Request Overview
This PR refines the --exclude option for the make-pot command by adding node_modules and wordpress directories to the exclusion list. This prevents WordPress Core strings from being unintentionally included in translation files when text domains are missing, improving performance and avoiding incorrect string extraction.
- Adds
node_modulesandwordpressto the exclude list for the i18n pot generation command - Prevents inclusion of WordPress Core strings in translation files
- Improves performance by excluding unnecessary directories during string extraction
circlecube
previously approved these changes
Aug 11, 2025
Ah yes, you're right! I think it is better to not include them. We should remove these where they are listed instead. |
These are excluded by default.
circlecube
approved these changes
Aug 11, 2025
--exclude option for make-potmake-pot command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This makes a few changes to the
make-potcommand:wordpressdirectory to the exclude list for themake-potcommand: Because WordPress is installed as a Composer dependency, the strings in WordPress Core could unintentionally be included in translation files when a text domain is missing (see Avoid translating installed dependencies wp-module-help-center#218).--domain: The default value for--domainis the project slug whenText Domainis not specified in the main plugin or theme file. Explicitly passing the text domain avoids the scenario where someone checks the repository out in a folder with a custom name.Type of Change
Production
Development
Visual
Checklist
Further comments