Skip to content

Conversation

arunshenoy99
Copy link
Member

Proposed changes

This PR fixes an issue where Link Prefetch was always disabled regardless of capabilities, due to the system falling back to default settings when the nfd_link_prefetch_settings option did not exist. The defaults had both activeOnDesktop and activeOnMobile set to false, causing Link Prefetch to remain inactive even when capabilities like hasLinkPrefetchClick or hasLinkPrefetchHover were present. This fix updates the runtime logic to apply capability-based defaults only when the option is missing.

Type of Change

Production

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update
  • Refactoring / housekeeping (changes to files not directly related to functionality)

Development

  • Tests
  • Dependency update
  • Environment update / refactoring
  • Documentation Update

Video

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@arunshenoy99 arunshenoy99 requested a review from a team as a code owner July 6, 2025 10:02
Copy link
Contributor

github-actions bot commented Jul 6, 2025

@arunshenoy99 arunshenoy99 merged commit 6c1b25d into main Jul 7, 2025
15 of 18 checks passed
@arunshenoy99 arunshenoy99 deleted the fix/link-prefetch branch July 7, 2025 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants