Skip to content

Conversation

arunshenoy99
Copy link
Member

@arunshenoy99 arunshenoy99 commented Jun 24, 2025

Proposed changes

This solves the issue where setting the option to false returned false when the option didn’t exist, because WordPress treated it as a no-op, the initial non-existent option evaluated to false, and the new value was also false, so no update was made. Retains the false check so that we don't mess up the .htaccess file.

Type of Change

Production

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update
  • Refactoring / housekeeping (changes to files not directly related to functionality)

Development

  • Tests
  • Dependency update
  • Environment update / refactoring
  • Documentation Update

Video

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@arunshenoy99 arunshenoy99 requested a review from a team as a code owner June 24, 2025 15:19
Copy link
Contributor

github-actions bot commented Jun 24, 2025

abhijitb
abhijitb previously approved these changes Jun 24, 2025
@arunshenoy99 arunshenoy99 mentioned this pull request Jun 24, 2025
14 tasks
@arunshenoy99 arunshenoy99 merged commit 0969b96 into main Jun 24, 2025
10 of 15 checks passed
@arunshenoy99 arunshenoy99 deleted the fix/skip404-option branch June 24, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants