Fix Skip404 option saving flow when it does not exist #243
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This solves the issue where setting the option to false returned false when the option didn’t exist, because WordPress treated it as a no-op, the initial non-existent option evaluated to false, and the new value was also false, so no update was made. Retains the
false
check so that we don't mess up the.htaccess
file.Type of Change
Production
Development
Video
Checklist
Further comments