Skip to content

Conversation

zlateska
Copy link
Contributor

@zlateska zlateska commented Aug 6, 2025

Proposed changes

This PR fixes an issue where certain blocks were missing after installing a required plugin.

Type of Change

Production

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update
  • Refactoring / housekeeping (changes to files not directly related to functionality)

Development

  • Tests
  • Dependency update
  • Environment update / refactoring
  • Documentation Update

Visual

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@Copilot Copilot AI review requested due to automatic review settings August 6, 2025 14:42
Copilot

This comment was marked as outdated.

Copy link
Contributor

github-actions bot commented Aug 6, 2025

zlateska and others added 2 commits August 6, 2025 10:44
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
wpalani
wpalani previously approved these changes Aug 6, 2025
@zlateska zlateska requested review from Copilot and wpalani August 6, 2025 15:28
Copilot

This comment was marked as outdated.

@newfold-labs newfold-labs deleted a comment from Copilot AI Aug 6, 2025
@newfold-labs newfold-labs deleted a comment from Copilot AI Aug 6, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an issue where certain blocks were missing after plugin installation by improving the distinction between inactive and not-installed plugins, and ensuring proper plugin initialization timing.

  • Adds logic to differentiate between inactive plugins (which can be activated) vs not-installed plugins (which need installation)
  • Implements delayed reload mechanism with plugin-specific timeouts to allow proper block registration
  • Updates Jetpack module handling to ensure required modules are properly activated

Reviewed Changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
src/hooks/usePluginRequirements.js Adds hasNotInstalledPlugins function to distinguish not-installed from inactive plugins and updates CTB logic
src/hooks/usePluginManager.js Implements plugin-specific delays before reload and adds cache-busting timestamp parameter
includes/Services/PluginService.php Updates premium plugin activation logic and improves Jetpack module activation handling
includes/Data/PluginStatus.php Adds special Jetpack module status checking to ensure required modules are active
build/2.10.1/wonder-blocks.asset.php Updates asset version hash for build changes

@newfold-labs newfold-labs deleted a comment from Copilot AI Aug 6, 2025
@newfold-labs newfold-labs deleted a comment from Copilot AI Aug 6, 2025
@newfold-labs newfold-labs deleted a comment from Copilot AI Aug 6, 2025
@newfold-labs newfold-labs deleted a comment from Copilot AI Aug 6, 2025
@newfold-labs newfold-labs deleted a comment from Copilot AI Aug 6, 2025
@newfold-labs newfold-labs deleted a comment from Copilot AI Aug 6, 2025
@zlateska zlateska merged commit 223cb9d into main Aug 6, 2025
15 checks passed
@zlateska zlateska deleted the fix/allow-block-registration-after-plugin-installation branch August 6, 2025 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants