Skip to content

Conversation

desrosj
Copy link
Member

@desrosj desrosj commented Aug 4, 2025

Proposed changes

This standardizes the Node.js setup by:

  • Introducing an .nvmrc file specifying the version of Node.js to use when working with the repository.
  • Added engines to the package.json file.

Since 22.x is the current LTS version of Node.js, 22.11.0 is used as the minimum required version since it represents the release that transitioned the version from current to LTS status. The version of npm used (10.9.0) is the version bundled with 22.11.0

This addresses PRESS0-2908, PRESS0-2909, PRESS0-2910, PRESS0-2911.

Type of Change

Production

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update
  • Refactoring / housekeeping (changes to files not directly related to functionality)

Development

  • Tests
  • Dependency update
  • Environment update / refactoring
  • Documentation Update

Visual

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

This standardizes the Node.js setup by:
- Introducing an `.nvmrc` file specifying the version of Node.js to use when working with the repository.
- Added `engines` to the `package.json` file.

Some uncommitted changes to the lock file are also included.
@desrosj desrosj self-assigned this Aug 4, 2025
@Copilot Copilot AI review requested due to automatic review settings August 4, 2025 23:56
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR standardizes the Node.js setup for the repository by specifying required Node.js and npm versions. It establishes Node.js 22.x as the standard version to ensure consistency across development environments.

  • Adds .nvmrc file to specify Node.js version for nvm users
  • Introduces engines field in package.json to enforce minimum Node.js and npm versions

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File Description
package.json Adds engines field specifying minimum Node.js 22.11.0 and npm 10.9.0 requirements
.nvmrc Creates new file specifying Node.js version 22 for nvm compatibility

Copy link
Contributor

github-actions bot commented Aug 4, 2025

girish-lokapure
girish-lokapure previously approved these changes Aug 8, 2025
@wpscholar wpscholar merged commit d75e65c into main Aug 12, 2025
14 checks passed
@wpscholar wpscholar deleted the standarize-node-setup branch August 12, 2025 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants