Skip to content

Conversation

circlecube
Copy link
Member

Proposed changes

See PRESS10-34

Small test-related change to add the testIsolation flag to the test and combine into one run.

Type of Change

Production

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update
  • Refactoring / housekeeping (changes to files not directly related to functionality)

Development

  • Tests
  • Dependency update
  • Environment update / refactoring
  • Documentation Update

Video

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@circlecube circlecube requested review from bradp and zlateska December 18, 2024 18:38
it should close the welcome guide if it displays so the test can perform
@wpscholar
Copy link
Member

@circlecube - We should also update the code in this module to actually run its own tests.

@circlecube circlecube merged commit b7d672d into main Jan 13, 2025
@circlecube circlecube deleted the update/testisolation branch January 13, 2025 23:02
@circlecube circlecube mentioned this pull request Mar 3, 2025
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants