Skip to content

Return zero state interface if no plan is returned #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Return zero state interface if no plan is returned #151

wants to merge 2 commits into from

Conversation

crodriguezbrito
Copy link
Contributor

@crodriguezbrito crodriguezbrito commented May 6, 2025 •
edited
Loading

Proposed changes

This PR will return zero state interface if no plan is returned. see #PRESS10-185

Screenshot_solutions_page

Note: I removed some Cypress checks because the banner should not appear if you don’t have a plan.

Type of Change

Production

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update
  • Refactoring / housekeeping (changes to files not directly related to functionality)

Development

  • Tests
  • Dependency update
  • Environment update / refactoring
  • Documentation Update

Video

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

circlecube
circlecube requested changes May 6, 2025
View reviewed changes
Copy link
Member

@circlecube circlecube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a comment in the ticket, but I think the wording in the ticket is confusing and this should be reverted, and rather than remove the upgrade banner from this page, we should add it to the zero state in the plugin page app.

@crodriguezbrito crodriguezbrito mentioned this pull request Jun 6, 2025
Merged
14 tasks
@circlecube
Copy link
Member

Closing in favor of #180

@circlecube circlecube closed this Jun 6, 2025
@circlecube circlecube deleted the update/PRESS10-185 branch June 6, 2025 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@circlecube circlecube circlecube requested changes

@GiuseppeArcifa GiuseppeArcifa Awaiting requested review from GiuseppeArcifa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crodriguezbrito @circlecube