Skip to content

Conversation

circlecube
Copy link
Member

Proposed changes

Adding basename attribute to plugin buttons in addnew app too.

While I was in there, I also made string updates and made some related translation method cleanup. see PRESS10-185

Type of Change

Production

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update
  • Refactoring / housekeeping (changes to files not directly related to functionality)

Development

  • Tests
  • Dependency update
  • Environment update / refactoring
  • Documentation Update

Video

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@circlecube circlecube requested a review from a team April 24, 2025 16:28
@circlecube circlecube self-assigned this Apr 24, 2025
wpscholar
wpscholar previously approved these changes Apr 24, 2025
@circlecube circlecube merged commit 2f5f3d0 into main Apr 24, 2025
1 of 2 checks passed
@circlecube circlecube deleted the update/strings-and-basename-for-plugins-app branch April 24, 2025 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants